[webkit-reviews] review requested: [Bug 86314] LayerFlushScheduler should be suspended when painting is suspended (background tabs, etc.) : [Attachment 141620] patch for landing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 13 17:06:24 PDT 2012


Tim Horton <timothy_horton at apple.com> has asked  for review:
Bug 86314: LayerFlushScheduler should be suspended when painting is suspended
(background tabs, etc.)
https://bugs.webkit.org/show_bug.cgi?id=86314

Attachment 141620: patch for landing
https://bugs.webkit.org/attachment.cgi?id=141620&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
(In reply to comment #6)
> (From update of attachment 141615 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=141615&action=review
> Could even consider an unconditional call to schedule, since schedule already
checks the suspend count.

Our implementation does, but there's no reason it should/no guarantee another
implementation would. I think it makes more sense to have that check in the
caller, no?

Attaching a patch for landing with andersca's OK.


More information about the webkit-reviews mailing list