[webkit-reviews] review canceled: [Bug 86306] DFG should be able to optimize foo.apply(bar, arguments) : [Attachment 141611] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 13 17:03:35 PDT 2012


Filip Pizlo <fpizlo at apple.com> has canceled Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 86306: DFG should be able to optimize foo.apply(bar, arguments)
https://bugs.webkit.org/show_bug.cgi?id=86306

Attachment 141611: the patch
https://bugs.webkit.org/attachment.cgi?id=141611&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I forgot that optimizing op_call_varargs to use arguments directly implies that
we need to first check that the arguments object has not been created.	This
revised version of the patch does this, though imperfectly; the only hole (use
of static speculation) will be fixed in
https://bugs.webkit.org/show_bug.cgi?id=86327.


More information about the webkit-reviews mailing list