[webkit-reviews] review denied: [Bug 86314] LayerFlushScheduler should be suspended when painting is suspended (background tabs, etc.) : [Attachment 141603] patch, maybe?

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 86314: LayerFlushScheduler should be suspended when painting is suspended
(background tabs, etc.)
https://bugs.webkit.org/show_bug.cgi?id=86314

Attachment 141603: patch, maybe?
https://bugs.webkit.org/attachment.cgi?id=141603&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141603&action=review


> Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp:40
> -    if (m_isSuspended)
> +    if (m_suspendCount)
>	   return;
>      
> -    m_isSuspended = true;
> +    m_suspendCount++;
>      invalidate();

It’s fine to skip the invalidate, but seems wrong to skip the suspend count
bumping.

> Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp:49
> -    if (!m_isSuspended)
> +    if (!m_suspendCount)
>	   return;
>      
> -    m_isSuspended = false;
> +    m_suspendCount--;
>      schedule();

Seems we should only schedule if the suspend count becomes zero.