[webkit-reviews] review granted: [Bug 86319] Unify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp : [Attachment 141606] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Barton
<dbarton at mathscribe.com>'s request for review:
Bug 86319: Unify RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp
https://bugs.webkit.org/show_bug.cgi?id=86319

Attachment 141606: Patch
https://bugs.webkit.org/attachment.cgi?id=141606&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141606&action=review


> Source/WebCore/ChangeLog:14
> +	   (WebCore):

Please remove bogus lines like this from the ChangeLog, or you could fix the
prepare-ChangeLog script to not emit those.

> Source/WebCore/ChangeLog:19
> +	   (WebCore):

Ditto.

> Source/WebCore/ChangeLog:22
> +	   (WebCore):

Ditto.

> Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:91
> +    int frontWidth = static_cast<int>(roundf(gFrontWidthEms *
style()->fontSize()));

It seems strange to call static_cast<int>(roundf()) since lroundf does the same
thing without a cast.

> Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:111
> +	   int partDipHeight = static_cast<int>(roundf((1 -
gRootRadicalDipLeftPointYPos) * baseHeight));

Ditto.

> Source/WebCore/rendering/mathml/RenderMathMLRoot.h:41
> +    virtual void computePreferredLogicalWidths() OVERRIDE;

Why protected rather than private?