[webkit-reviews] review canceled: [Bug 84435] [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges() : [Attachment 138965] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 84435: [EFL][DRT] EFL's DRT needs to support
LayoutTestController.dumpIconChanges()
https://bugs.webkit.org/show_bug.cgi?id=84435

Attachment 138965: Patch
https://bugs.webkit.org/attachment.cgi?id=138965&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Now emitting the "icon,changed" signal on all frames, not just the main one.
This is consistent with what the Chromium port is doing.
I also converted the main frame runtime check in
FrameLoaderClientEfl::dispatchDidReceiveIcon() into an assertion since
IconController loads icons only for the main frame (consistent with other ports
such as Mac and GTK).