[webkit-reviews] review denied: [Bug 70304] width/height attributes of input element should be supported when the type of the input element is image. : [Attachment 140485] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Dongwoo Joshua Im
<dw.im at samsung.com>'s request for review:
Bug 70304: width/height attributes of input element should be supported when
the type of the input element is image.
https://bugs.webkit.org/show_bug.cgi?id=70304

Attachment 140485: Patch
https://bugs.webkit.org/attachment.cgi?id=140485&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140485&action=review


>
LayoutTests/fast/forms/input-width-height-attributes-without-renderer-loaded-im
age.html:15
> +<input type="image" id="imageInput" src="resources/green.jpg"
style="display:none">
> +<div id="console"></div>
> +<script language="JavaScript">
> +    var e = document.getElementById("imageInput");
> +    shouldBe('e.width', '0');
> +    shouldBe('e.height', '0');
> +    finishJSTest();

This is a test for *loaded* image.  So the test should be asynchronous and need
to wait for image loading.

>
LayoutTests/fast/forms/input-width-height-attributes-without-renderer-not-loade
d-image.html:20
> +    var e = document.getElementById("imageSlow");
> +
> +    document.onreadystatechange = function() {
> +	   readyState = document.readyState;
> +	   if (readyState == 'complete') {
> +	       finishJSTest();
> +	   } else if (readyState == 'loading' || readyState == 'interactive') {

> +	       shouldBe('e.width', '0');
> +	       shouldBe('e.height', '0');

This is a test for *not loaded* image.	So we don't need to make this
asynchronous.