[webkit-reviews] review requested: [Bug 85533] Don't require FrameLoaderClient to manufacture a commitData() call for empty documents : [Attachment 140084] fix gtk compile

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 85533: Don't require FrameLoaderClient to manufacture a commitData() call
for empty documents
https://bugs.webkit.org/show_bug.cgi?id=85533

Attachment 140084: fix gtk compile
https://bugs.webkit.org/attachment.cgi?id=140084&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=140084&action=review


It's surprising that many clients had this m_hasRepresentation logic. Looks
good to me, except for WK1 part that I couldn't understand.

> Source/WebKit/mac/ChangeLog:9
> +	   * WebView/WebHTMLRepresentation.mm:
> +	   (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):

Could you add an explanation of what this is changing? It's not as closely
connected to the goal of this patch as some other ports, so the change looks a
bit confusing.