[webkit-reviews] review requested: [Bug 27577] [CSS3 Backgrounds and Borders] Add background-size to the background shorthand : [Attachment 140100] Patch-updated

[bugzilla-daemon at webkit.org]

Joe Thomas <joethomas at motorola.com> has asked  for review:
Bug 27577: [CSS3 Backgrounds and Borders] Add background-size to the background
shorthand
https://bugs.webkit.org/show_bug.cgi?id=27577

Attachment 140100: Patch-updated
https://bugs.webkit.org/attachment.cgi?id=140100&action=review

------- Additional Comments from Joe Thomas <joethomas at motorola.com>
Added the background-size property to StylePropertySet::getPropertyValue &
StylePropertyShorthand::backgroundShorthand()

But I haven't added background-size to background shorthand property in
CSSComputedStyleDeclaration. Tried to add / seperator between
background-position and background-size in
CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties with 

 if (shorthand.properties()[i] == CSSPropertyBackgroundSize)
    list->append(cssValuePool().createValue("/",
CSSPrimitiveValue::CSS_STRING));
    
This adds the seperator into the shorthand with single quotes, like 

rgb(255, 0, 0) url(dummy://test.png) repeat scroll 50px 50px '/' 50% 25%

The single quote is getting added to the separator in
CSSPrimitiveValue::customCssText() with
"quoteCSSStringIfNeeded(m_value.string)". 

Can someone please suggest a way to avoid this? Is it a good idea to create a
PlainTextCSSValue class derived from CSSValue and return the string alone
without any modification?