[webkit-reviews] review granted: [Bug 62487] Keep overlap testing for compositing on pages with 3d transforms when possible : [Attachment 139947] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 62487: Keep overlap testing for compositing on pages with 3d transforms
when possible
https://bugs.webkit.org/show_bug.cgi?id=62487

Attachment 139947: Patch
https://bugs.webkit.org/attachment.cgi?id=139947&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=139947&action=review


r=me

> Source/WebCore/ChangeLog:43
> +	   (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform): No
longer check
> +	   perspective here, since that doesn't affect whether _this_ layer
should disable
> +	   overlap testing. Checking for a non-affine transform is sufficient.

What does overlap testing have to do with whether a transform is non-identity?
Is this method misnamed?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1335
> +    // FIXME: remove this method.
>  }

Why not just remove it?