[webkit-reviews] review granted: [Bug 84304] WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be implemented for WebKit2 : [Attachment 139945] Patch v5

[bugzilla-daemon at webkit.org]

Jessie Berlin <jberlin at webkit.org> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 84304: WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
implemented for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84304

Attachment 139945: Patch v5
https://bugs.webkit.org/attachment.cgi?id=139945&action=review

------- Additional Comments from Jessie Berlin <jberlin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139945&action=review


r=me

> Tools/TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:45
> +    WKBundlePostMessage(InjectedBundleController::shared().bundle(),
Util::toWK("DidReceiveWillSendSubmitEvent").get(), values);

You should probably check the values here as well.

> Tools/TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html:7
> +		       return;

Why is this window.location.search check and early return necessary?

> Tools/TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html:15
> +	       <input type="hidden" name="hiddenField" value="hidden field">

It might be nice to add more fields + values here so that you can check they
are being reported correctly through the API (see previous comment).