[webkit-reviews] review granted: [Bug 85410] Need tests for PerfTestRunner.computeStatistics : [Attachment 139898] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 2 15:52:24 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Tom Zakrajsek
<tomz at codeaurora.org>'s request for review:
Bug 85410: Need tests for PerfTestRunner.computeStatistics
https://bugs.webkit.org/show_bug.cgi?id=85410
Attachment 139898: Patch
https://bugs.webkit.org/attachment.cgi?id=139898&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139898&action=review
> LayoutTests/fast/harness/perftests/perf-runner-compute-statistics.html:15
> + // don't want side effects on the input array, so...
Please don't abbreviate "original".
> PerformanceTests/resources/runner.js:2
> +// There are tests for computeStatistics() located in
> +// LayoutTests/fast/harness/perftests
You can probably fit this in one line.
More information about the webkit-reviews
mailing list