[webkit-reviews] review granted: [Bug 85426] webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker. : [Attachment 139896] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 15:51:21 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Raphael Kubo da Costa (rakuco)
<rakuco at webkit.org>'s request for review:
Bug 85426: webkitpy: Use a SystemHost instead of PlatformInfo in the PNG
checker.
https://bugs.webkit.org/show_bug.cgi?id=85426

Attachment 139896: Patch
https://bugs.webkit.org/attachment.cgi?id=139896&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139896&action=review


> Tools/Scripts/webkitpy/common/system/systemhost_mock.py:40
> +	   self.filesystem = filesystem or MockFileSystem()

Since things like executive, filesystem are public properties, I sometimes will
construct the object with the default values and then set the property, rather
than passing it in (which is why filesystem wasn't previously a parameter). I
don't know that my approach was better or worse than this, though.


More information about the webkit-reviews mailing list