[webkit-reviews] review granted: [Bug 82619] Web Inspector: SnippetsScriptMapping should process existing snippets on load. : [Attachment 134595] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 29 09:21:24 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 82619: Web Inspector: SnippetsScriptMapping should process existing
snippets on load.
https://bugs.webkit.org/show_bug.cgi?id=82619

Attachment 134595: Patch
https://bugs.webkit.org/attachment.cgi?id=134595&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134595&action=review


> Source/WebCore/inspector/front-end/SnippetsModel.js:67
> +	   var result = [];

Nit: you could introduce Object.prototype.valuesArray


More information about the webkit-reviews mailing list