[webkit-reviews] review granted: [Bug 82621] Web Inspector: check more likely condition first in HeapSnapshot._buildAggregates : [Attachment 134598] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 29 09:16:43 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 82621: Web Inspector: check more likely condition first in
HeapSnapshot._buildAggregates
https://bugs.webkit.org/show_bug.cgi?id=82621
Attachment 134598: Patch
https://bugs.webkit.org/attachment.cgi?id=134598&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134598&action=review
> Source/WebCore/inspector/front-end/HeapSnapshot.js:1094
> + if (node.selfSize === 0 && !node.isNative)
We don't compare to 0 in WebKit, use !node.selfSize.
More information about the webkit-reviews
mailing list