[webkit-reviews] review denied: [Bug 82336] Make it possible to use accelerated compositing for page overlay fading : [Attachment 134549] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Lars Knudsen
<lars.knudsen at nokia.com>'s request for review:
Bug 82336: Make it possible to use accelerated compositing for page overlay
fading
https://bugs.webkit.org/show_bug.cgi?id=82336

Attachment 134549: Patch
https://bugs.webkit.org/attachment.cgi?id=134549&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134549&action=review


> Source/WebKit2/WebProcess/WebPage/DrawingArea.h:78
> +    // Return false if accelerated compositing should not be used for
overlay opacity.

I'd say "If this function returns false, PageOverlay should apply opacity when
painting.

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:231
> +    scheduleCompositingLayerSync();

Why is this needed?

> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:-127
> -    m_fractionFadedIn = 0.0;

m_fractionFadeIn would have an undefined value before the animation.

> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:162
> +    if (!m_webPage->drawingArea()->setPageOverlayOpacity(fractionFadedIn)) {

> +	   m_fractionFadedIn = fractionFadedIn;
> +	   setNeedsDisplay();
> +    }

if you add this:
} else {
    // Opacity is handled externally, in DrawingArea or LayerTreeHost.
    m_fractionFadeIn = 1;
}

you can leave the member initialization intact.