[webkit-reviews] review denied: [Bug 82594] [BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake : [Attachment 134543] Add more enabler to cmake config template.

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 82594: [BlackBerry] Add more ENABLERS to cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=82594

Attachment 134543: Add more enabler to cmake config template.
https://bugs.webkit.org/attachment.cgi?id=134543&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=134543&action=review


HAve a good look if we really need all of these.

> Source/cmakeconfig.h.cmake:15
> +#cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION

I dont think this exists anymore.

> Source/cmakeconfig.h.cmake:16
> +#cmakedefine01 ENABLE_DATAGRID

Ditto.

> Source/cmakeconfig.h.cmake:32
> +#cmakedefine01 ENABLE_GROUP_BASED_DATABASE

Ditto.