[webkit-reviews] review granted: [Bug 82407] [chromium] Merge ChromiumDataObject and DataTransferItemListChromium. : [Attachment 134191] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 82407: [chromium] Merge ChromiumDataObject and
DataTransferItemListChromium.
https://bugs.webkit.org/show_bug.cgi?id=82407

Attachment 134191: Patch
https://bugs.webkit.org/attachment.cgi?id=134191&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=134191&action=review


Looks like your patch needs to be rebased.  Please make sure to have a green
ews run on all the bots before landing.

> Source/WebCore/ChangeLog:14
> +	   * platform/chromium/ChromiumDataObject.cpp:

Please mention here that this is replacing DataTransferItemListChromium.

> Source/WebCore/platform/chromium/ChromiumDataObject.h:59
> +    // DataTransferItemList support.
> +    size_t length() const;

Should ChromiumDataObject implement DataTransferItemList?

> Source/WebCore/platform/chromium/ChromiumDataObjectItem.h:49
> +class ChromiumDataObjectItem : public RefCounted<ChromiumDataObjectItem> {

Should ChromiumDataObjectItem implement DataTransferItem?