[webkit-reviews] review granted: [Bug 76684] Respects font fallback list while webfonts are loading : [Attachment 131947] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 76684: Respects font fallback list while webfonts are loading
https://bugs.webkit.org/show_bug.cgi?id=76684

Attachment 131947: Patch
https://bugs.webkit.org/attachment.cgi?id=131947&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131947&action=review


ok. In the future, please don't wait a week if you don't get a response from a
reviewer. In this particular case, you have my email, and heck, you even have
my IM. We all get a ton of mail -- it's likely that some will fall through
cracks. Be persistent :)

> Source/WebCore/css/CSSSegmentedFontFace.cpp:93
> +    if (!numRanges)
> +	   newFontData->appendRange(FontDataRange(0, 0x7FFFFFFF,
faceFontData));

Can do early return here.