[webkit-reviews] review granted: [Bug 82241] NRWT should retry failures serially : [Attachment 133893] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 82241: NRWT should retry failures serially
https://bugs.webkit.org/show_bug.cgi?id=82241

Attachment 133893: Patch
https://bugs.webkit.org/attachment.cgi?id=133893&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133893&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:710
> +    def _run_tests(self, file_list, result_summary, num_workers=0):

Sorry for all the nitpicking, but I usually only like to use optional
parameters as a last choice. You should be able to just pass in num_workers to
both places it's called (line 897 and line 911), and then change line 751 to
min(num_workers, len(all_shards).