[webkit-reviews] review granted: [Bug 82209] [jhbuild] Use $MAKE if it is defined to build jhbuild itself. : [Attachment 133872] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Raphael Kubo da Costa
<rakuco at FreeBSD.org>'s request for review:
Bug 82209: [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
https://bugs.webkit.org/show_bug.cgi?id=82209

Attachment 133872: Patch
https://bugs.webkit.org/attachment.cgi?id=133872&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133872&action=review


>>> Tools/jhbuild/jhbuild-wrapper:96
>>> +	 make = shlex.split(os.environ.get('MAKE', 'make'))
>> 
>> Why not just os.environ.get('MAKE', 'make').split()[0] ?
> 
> If MAKE is set to "make -j3" that will only give me "make" and "-j3" will be
lost. shlex.split("make -j3") gives me ['make', '-j3'].

Makes sense, thanks!