[webkit-reviews] review denied: [Bug 59367] [GTK] DRT missing didRunInsecureContent notification : [Attachment 133501] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Simon Pena
<spena at igalia.com>'s request for review:
Bug 59367: [GTK] DRT missing didRunInsecureContent notification
https://bugs.webkit.org/show_bug.cgi?id=59367

Attachment 133501: Patch
https://bugs.webkit.org/attachment.cgi?id=133501&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133501&action=review


Thanks for the contribution. I think the documentation could use some love and
perhaps you could figure out the other insecure content tests aren't passing
(if they aren't) and add a comment.

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:443
> +	* Invoked when insecure content is run

This documentation could be improved quite a bit. For instance you could give
examples of what type of insecure content trigger this signal.