[webkit-reviews] review granted: [Bug 81657] MediaStream API (JSEP): Introducing PeerConnection00 and IceCallback : [Attachment 133475] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 81657: MediaStream API (JSEP): Introducing PeerConnection00 and IceCallback
https://bugs.webkit.org/show_bug.cgi?id=81657

Attachment 133475: Patch
https://bugs.webkit.org/attachment.cgi?id=133475&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133475&action=review


> Source/WebCore/Modules/mediastream/PeerConnection00.cpp:101
> +	   if (*i == "audio")

This are supposed to be case sensitive?

> Source/WebCore/Modules/mediastream/PeerConnection00.cpp:126
> +    return SessionDescription::create(descriptor);

Should this be descriptor.release()?  It looks like you're transferring
ownership of descriptor into this object.

> Source/WebCore/Modules/mediastream/PeerConnection00.cpp:141
> +    return SessionDescription::create(descriptor);

Should this be descriptor.release()?  It looks like you're transferring
ownership of descriptor into this object.

> Source/WebCore/Modules/mediastream/PeerConnection00.cpp:234
> +    else if (options == "no_relay")

Again, these are also supposed to be case sensitive?