[webkit-reviews] review denied: [Bug 71207] An extra line break is inserted when pasting into a font element : [Attachment 133329] First try

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 71207: An extra line break is inserted when pasting into a font element
https://bugs.webkit.org/show_bug.cgi?id=71207

Attachment 133329: First try
https://bugs.webkit.org/attachment.cgi?id=133329&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133329&action=review


> Source/WebCore/editing/ReplaceSelectionCommand.cpp:116
> +static Position nextPositionInContainerNode(Position pos)

Please don't use abbreviations like pos.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:120
> +    Node* n = pos.deprecatedNode();	  

You should use pos.containerNode(). Also please don't use one-letter variable
like n.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:125
> +    return createLegacyEditingPosition(parent, n->nodeIndex() + 1);

Why do we always want to move up in the node hierarchy? If we had a bunch of
siblings after pos's container node, then we'll still want to skip those. r-
because I don't think this is a correct fix.