[webkit-reviews] review granted: [Bug 78726] Text should overflow when list item height set to 0 : [Attachment 133327] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 78726: Text should overflow when list item height set to 0
https://bugs.webkit.org/show_bug.cgi?id=78726

Attachment 133327: Patch
https://bugs.webkit.org/attachment.cgi?id=133327&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133327&action=review


> Source/WebCore/rendering/RenderListItem.cpp:384
> +    // Paint a zero-height list item if it allows content overflow without
clipping.

allows content _to_ overflow ..?

Overall, this comment is just a transcription of the code below so it could be
dropped. This was just a bad optimization and we should be comparing the
repaint rectangle vs the overflow rectangle like some other paint functions
AFAICT.