[webkit-reviews] review granted: [Bug 81492] Use CSSPrimitiveValue::convertToLength() in a few places. : [Attachment 132949] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 81492: Use CSSPrimitiveValue::convertToLength() in a few places.
https://bugs.webkit.org/show_bug.cgi?id=81492

Attachment 132949: Patch
https://bugs.webkit.org/attachment.cgi?id=132949&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132949&action=review


Seems reasonable.

>>> Source/WebCore/css/CSSPrimitiveValueMappings.h:34
>>> +#include "CSSCalculationValue.h"
>> 
>> Alphabetical sorting problem.  [build/include_order] [4]
> 
> It lies!

It thinks ColorSpace should be after CSS.  the capital S is before all lower
case letters, I believe.