[webkit-reviews] review granted: [Bug 81843] refactor flexbox in preparation for flex-line-pack : [Attachment 133142] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 81843: refactor flexbox in preparation for flex-line-pack
https://bugs.webkit.org/show_bug.cgi?id=81843

Attachment 133142: Patch
https://bugs.webkit.org/attachment.cgi?id=133142&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133142&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:1009
> +	       if (flexAlignForChild(child) == AlignBaseline &&
minMarginAfterBaseline)

Nit: I'd move the minMarginAfterBaseline check to the outer for-loop and
early-continue:
if (!minMarginAfterBaseline)
    continue;