[webkit-reviews] review granted: [Bug 38025] Every call to RenderObject::setAnimatableStyle() iterates through all m_compositeAnimations: potentially O(N^2) : [Attachment 132744] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 38025: Every call to RenderObject::setAnimatableStyle() iterates through
all m_compositeAnimations: potentially O(N^2)
https://bugs.webkit.org/show_bug.cgi?id=38025

Attachment 132744: Patch
https://bugs.webkit.org/attachment.cgi?id=132744&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132744&action=review


> LayoutTests/animations/animation-welcome-safari.html:124
> +	   document.body.className = "go"

semicolon missing

> Source/WebCore/ChangeLog:7
> +	   This patchs implements updateAnimationTimerForRenderer, it just
checks the timeToNextService for
> +	   the current RenderObject reducing the amount of iterations.

Typo "patchs". I also suggest:

Implement updateAnimationTimerForRender. This reduces unnecessary animation
steps on the current RenderObject by checking the value of timeToNextService
before starting a new timer.