[webkit-reviews] review granted: [Bug 80571] [mac] Restore color space switching code to run-webkit-tests : [Attachment 132868] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 80571: [mac] Restore color space switching code to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=80571

Attachment 132868: patch
https://bugs.webkit.org/attachment.cgi?id=132868&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132868&action=review


> Tools/DumpRenderTree/mac/LayoutTestHelper.m:38
> +// This is a simple helper app that changes the ColorSync profile to the

I think the comment should say "the color profile for the main display".

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:51
> +    CFUUIDRef mainDisplay =
CGDisplayCreateUUIDFromDisplayID(CGMainDisplayID());

mainDisplayID would be a better name.

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:84
> +	   fprintf(stderr, "Failed to set color profile for main display!  Many
pixel tests may fail as a result.\n");

One space after the ! pls.

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:117
> +    exit(128 + sig);

What is 128 + sig?

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:59
> -    [m_window setColorSpace:[[NSScreen mainScreen] colorSpace]];
> +    [m_window setColorSpace:[NSColorSpace genericRGBColorSpace]];

Does DRT need a similar change?