[webkit-reviews] review granted: [Bug 80401] [BlackBerry] Credential save and autofill implemetation : [Attachment 132177] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 80401: [BlackBerry] Credential save and autofill implemetation
https://bugs.webkit.org/show_bug.cgi?id=80401

Attachment 132177: Patch
https://bugs.webkit.org/attachment.cgi?id=132177&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=132177&action=review


Looks good, see if you can fix before landing, and Leo or Charles can help cq+
or commit for you.

> Source/WebKit/blackberry/Api/WebPage.cpp:2024
> +    WebCore::Credential inputCredential(username, password,
WebCore::CredentialPersistenceNone);

You dont need WebCore:: prefix in this file.

> Source/WebKit/blackberry/Api/WebPage_p.h:180
> +    virtual PageClientBlackBerry::SaveCredentialType
notifyShouldSaveCredential(bool);

PageClientBlackBerry:: prefix might be not needed.