[webkit-reviews] review granted: [Bug 81597] [Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API : [Attachment 132727] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 81597: [Chromium] IndexedDB: Expose necessary IDB exception codes through
WebKit API
https://bugs.webkit.org/show_bug.cgi?id=81597

Attachment 132727: Patch
https://bugs.webkit.org/attachment.cgi?id=132727&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132727&action=review


> Source/WebKit/chromium/public/WebIDBDatabaseException.h:34
> +#include "platform/WebCommon.h"

nit: looks like you can do away with this include

> Source/WebKit/chromium/public/WebIDBDatabaseException.h:38
> +// These values must match WebCore::IDBDatabaseException values

we usually don't leave comments like these in the header files.  if someone
renames
IDBDatabaseException, they are probably unlikely to search for, find and then
revise
this comment.