[webkit-reviews] review granted: [Bug 81535] NRWT runs some tests that are skipped with -i command line option : [Attachment 132677] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 81535: NRWT runs some tests that are skipped with -i command line option
https://bugs.webkit.org/show_bug.cgi?id=81535

Attachment 132677: Patch
https://bugs.webkit.org/attachment.cgi?id=132677&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132677&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:872
> +	       for test in expectation_line.matching_tests:
> +		   self._model._clear_expectations_for_test(test,
expectation_line)
> +		   self._model._test_to_expectation_line[test] =
expectation_line
> +		   self._model._add_test(test, expectation_line,
overrides_allowed=True)

Could you instead add a boolean to add_expectation_line? Something like
overwrite_existing? I'm not a huge fan of duplicating accounting code like
this. If the code changes in add_expectation_line, we'd almost certainly want
it to change here to.