[webkit-reviews] review granted: [Bug 76686] HistoryItem not updated properly when a form submission begins before a previous form submission has finished : [Attachment 132665] v3 patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 76686: HistoryItem not updated properly when a form submission begins
before a previous form submission has finished
https://bugs.webkit.org/show_bug.cgi?id=76686

Attachment 132665: v3 patch
https://bugs.webkit.org/attachment.cgi?id=132665&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132665&action=review


> Source/WebCore/loader/FrameLoader.cpp:2669
> -    } else
> +    } else {
> +	   // must grab this now, since this load may stop the previous load
and clear this flag
> +	   bool isRedirect = m_quickRedirectComing;
>	   loadWithNavigationAction(workingResourceRequest, action,
lockHistory, loadType, formState.release());	
> +	   if (isRedirect) {
> +	       m_quickRedirectComing = false;
> +	       if (m_provisionalDocumentLoader)
> +		   m_provisionalDocumentLoader->setIsClientRedirect(true);
> +	   }
> +    }

Is there any sense in factoring this logic out into a helper? I notice it's
identical to code in loadURL().