[webkit-reviews] review granted: [Bug 81247] Fix crbug 117957 - get settings scrolling with the wheel again. : [Attachment 132087] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted  review:
Bug 81247: Fix crbug 117957 - get settings scrolling with the wheel again.
https://bugs.webkit.org/show_bug.cgi?id=81247

Attachment 132087: Patch
https://bugs.webkit.org/attachment.cgi?id=132087&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I misread this at first and thought it would call service..() multiple times on
subframes, but I see now it's directly calling serviceScrollAnimations() on the
scrollable areas.

I think this is OK.  I think it might be better to iterate through the Frame
tree to just hit FrameViews.  In any case, I think it's really important to get
better test coverage.

I'm fine with landing this patch as-is, or reverting the other patch so we can
shore it up a bit more.  Your call.