[webkit-reviews] review canceled: [Bug 81247] Fix crbug 117957 - get settings scrolling with the wheel again. : [Attachment 132115] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 14:03:10 PDT 2012


James Robinson <jamesr at chromium.org> has canceled Scott Byer
<scottbyer at chromium.org>'s request for review:
Bug 81247: Fix crbug 117957 - get settings scrolling with the wheel again.
https://bugs.webkit.org/show_bug.cgi?id=81247

Attachment 132115: Patch
https://bugs.webkit.org/attachment.cgi?id=132115&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
FrameView::serviceScriptedAnimations iterates through all child Frames, so I
was hoping this could piggyback on a similar iteration.  I think actually your
earlier patch would be better than iterating through Widgets, sorry for the
confusion. I'll R+ that patch.

Reverting is also a find option - we should figure out if we can cover up the
gap in test coverage to avoid doing this again.


More information about the webkit-reviews mailing list