[webkit-reviews] review granted: [Bug 81207] MediaStream API (JSEP): Introducing MediaHints and IceOptions : [Attachment 132021] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 10:59:36 PDT 2012


Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 81207: MediaStream API (JSEP): Introducing MediaHints and IceOptions
https://bugs.webkit.org/show_bug.cgi?id=81207

Attachment 132021: Patch
https://bugs.webkit.org/attachment.cgi?id=132021&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132021&action=review


> Source/WebCore/platform/mediastream/IceOptions.h:55
> +    IceOptions(UseCandidatesOption useCandidates) :
m_useCandidates(useCandidates) { }

One-argument constructors should have the "explicit" keyword.


More information about the webkit-reviews mailing list