[webkit-reviews] review granted: [Bug 81206] MediaStream API (JSEP): Introducing SessionDescription : [Attachment 132030] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 81206: MediaStream API (JSEP): Introducing SessionDescription
https://bugs.webkit.org/show_bug.cgi?id=81206

Attachment 132030: Patch
https://bugs.webkit.org/attachment.cgi?id=132030&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=132030&action=review


> Source/WebCore/Modules/mediastream/SessionDescription.idl:41
> +	   // adds the specified candidate to the description
> +	   void addCandidate(in IceCandidate candidate);
> +
> +	   // serializes the description to SDP
> +	   DOMString toSdp();

Please remove these comments.  Folks should read the spec if they want to know
what these functions do.

> Source/WebCore/platform/mediastream/SessionDescriptionDescriptor.h:57
> +    SessionDescriptionDescriptor(const String& sdp);

One-argument constructors should have the "explicit" keyword.