[webkit-reviews] review granted: [Bug 81161] Remove duplicate error() impls in CachedResource subclasses : [Attachment 131939] fix style issues

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 81161: Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161

Attachment 131939: fix style issues
https://bugs.webkit.org/attachment.cgi?id=131939&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131939&action=review


Do these checkNotify() functions need to be public?

> Source/WebCore/loader/cache/CachedImage.cpp:388
>      setStatus(status);
> -    ASSERT(errorOccurred());
>      m_data.clear();
>      notifyObservers();
> -    setLoading(false);
> -    checkNotify();
> +    CachedResource::error(status);

This is not so great, with setStatus being called twice.