[webkit-reviews] review granted: [Bug 78303] [PerformanceTests] run-perf-tests should be able to handle Hz-based score. : [Attachment 131973] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 78303: [PerformanceTests] run-perf-tests should be able to handle Hz-based
score.
https://bugs.webkit.org/show_bug.cgi?id=78303

Attachment 131973: Patch
https://bugs.webkit.org/attachment.cgi?id=131973&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131973&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:294
>		   results[score.group(1)] = float(score.group(2))
> +		   if score.group(3):
> +		       unit = score.group(3)

Can we used the named groups instead? e.g. "(?Pblah...)" then
match.group('blah')

> PerformanceTests/ChangeLog:16
> +	   Running Dromaeo/dom-attr.html (1 of 1)

This

> PerformanceTests/ChangeLog:19
> +	   Finished: 30.616529 s

And this line are actually output into stderr so you should probably exclude
them (you can confirm this by piping stdout).