[webkit-reviews] review granted: [Bug 81054] Have webkit-patch rebaseline-test update test_expectations.txt : [Attachment 131746] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 81054: Have webkit-patch rebaseline-test update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81054

Attachment 131746: Patch
https://bugs.webkit.org/attachment.cgi?id=131746&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131746&action=review


looks fine w/ the one change to use port.all_test_configuration().

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:113
> +	   # FIXME: Support non-Chromium ports.

Nit: do you actually need this? what happens if you run a non-chromium port? I
would expect it to be mostly fine.

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:124
> +	   # FIXME: Do something more general here.

You should use port.all_test_configurations() and then just filter on the
version.