[webkit-reviews] review denied: [Bug 80323] [CSS Filters] Drop Shadow is not repainting correctly when repaint area is smaller than the filtered element : [Attachment 131927] Patch V2

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 80323: [CSS Filters] Drop Shadow is not repainting correctly when repaint
area is smaller than the filtered element
https://bugs.webkit.org/show_bug.cgi?id=80323

Attachment 131927: Patch V2
https://bugs.webkit.org/attachment.cgi?id=131927&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131927&action=review


I think this patch is too big. You should break it up, and fix one part at a
time.

> Source/WebCore/ChangeLog:11
> +	   The problem is that shadow and blur (and custom filters - although
not treated in this patch) need the full source image of
> +	   the surface that needs to be filtered. Until now the filter was
computed only using the area defined by the dirty repaint rectangle.
> +	   Those filters need full image source because they displace pixel
positions, meaning that pixels in the current dirty rectangle
> +	   have a dependency on pixels from the RenderLayer outside the dirty
rect. See the bug pictures for an example of how that could go wrong.

But that should already be taken care of by the inflation of the dirty rect,
no?