[webkit-reviews] review denied: [Bug 80499] [Forms] label.form attribute doesn't work : [Attachment 131799] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 80499: [Forms] label.form attribute doesn't work
https://bugs.webkit.org/show_bug.cgi?id=80499

Attachment 131799: Patch 1
https://bugs.webkit.org/attachment.cgi?id=131799&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131799&action=review


> Source/WebCore/html/HTMLLabelElement.cpp:88
> +{

The code is very similar to FormAssociated::insertedIntoTree() and
FormAssociated::resetFormOwner(). Please share the code.

> LayoutTests/fast/forms/form-attribute-expected.txt:NaN
>  PASS document.getElementsByTagName("button")[0].form is owner

Please remove FIXME in this file.

> LayoutTests/fast/forms/label/label-form-attribute.html:1
> +<DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

As you know, we already have some tests for 'form' attribute.
I recommend add test cases for 'label' to form-attribute.html and
form-attribute-nonexistence-form-id.html, and remove this file.

> LayoutTests/fast/forms/label/label-form-attribute.html:12
> +var html = '<dvi id=outer>';

typo: <dvi>