[webkit-reviews] review denied: [Bug 81087] Don't install libWebCoreTestSupport on OS X production builds : [Attachment 131801] patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Matt Lilek (pewtermoose)
<mlilek at apple.com>'s request for review:
Bug 81087: Don't install libWebCoreTestSupport on OS X production builds
https://bugs.webkit.org/show_bug.cgi?id=81087

Attachment 131801: patch
https://bugs.webkit.org/attachment.cgi?id=131801&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131801&action=review


> Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:35
> +SKIP_INSTALL = $(SKIP_INSTALL_$(BUILD_TYPE));
> +SKIP_INSTALL_Production = YES;

I don't know what BUILD_TYPE is. It wouldn't be what we want anyway. Since this
library is only used by DumpRenderTree and friends we want this installed only
when FORCE_TOOL_INSTALL = YES. See
Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig for where we do
this elsewhere.