[webkit-reviews] review denied: [Bug 80466] [Forms] The "output" element should have labels. : [Attachment 131772] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 21:20:02 PDT 2012


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 80466: [Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466

Attachment 131772: Patch 2
https://bugs.webkit.org/attachment.cgi?id=131772&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131772&action=review


The code change is ok.


>
LayoutTests/platform/chromium/fast/forms/label/labelable-elements-expected.txt:
48
>  Labelable: output [object HTMLOutputElement]
> -FAIL element.labels.length should be 1. Threw exception TypeError: Cannot
read property 'length' of null
> +PASS element.labels.length is 1

You need to update the following files too:

LayoutTests/platform/mac/fast/forms/label/labelable-elements-expected.txt
LayoutTests/fast/forms/label/labelable-elements-expected.txt


More information about the webkit-reviews mailing list