[webkit-reviews] review denied: [Bug 80403] [Forms] Hidden input element should not have labels. : [Attachment 131570] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 13 21:24:27 PDT 2012


Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 80403: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Attachment 131570: Patch 2
https://bugs.webkit.org/attachment.cgi?id=131570&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131570&action=review


> Source/WebCore/ChangeLog:12
> +	   Note: The HTML5 specification isn't clear for non-labelable
element's "labels"
> +	   attribute return value. FF and OP return empty node list. IE returns
null.

nit: 'FF' 'OP' are not so common abbreviations.

> LayoutTests/fast/forms/label/labelable-elements-expected.txt:84
> -FAIL element.labels should be undefined. Was [object NodeList]
> -PASS element.labels is not null
> +PASS element.labels is null

We need similar changes for
LayoutTests/platform/*/fast/forms/label/labelable-elements-expected.txt.


More information about the webkit-reviews mailing list