[webkit-reviews] review granted: [Bug 80898] Make ApplicationCacheHost::isApplicationCacheEnabled() const. : [Attachment 131424] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 80898: Make ApplicationCacheHost::isApplicationCacheEnabled() const.
https://bugs.webkit.org/show_bug.cgi?id=80898

Attachment 131424: Patch
https://bugs.webkit.org/attachment.cgi?id=131424&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
We generally try to not have const pointers to large objects like this one,
because it simply doesn't make sense.

So, it would be slightly better to fix chromium side to not keep a const
pointer. But there is no harm in this patch either.

Note that the existing line below is worse:

>	   DocumentLoader* documentLoader() const { return m_documentLoader; }

This is basically a sneaky way to remove constness (DocumentLoader owns
ApplicationCacheHost and a lot more).