[webkit-reviews] review canceled: [Bug 80856] Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent : [Attachment 131396] Patch.

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 80856: Split the extra logic out of
RenderObjectChildList::updateBeforeAfterContent
https://bugs.webkit.org/show_bug.cgi?id=80856

Attachment 131396: Patch.
https://bugs.webkit.org/attachment.cgi?id=131396&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131396&action=review


The rest of the change looks fine but I would like a green EWS!

> Source/WebCore/rendering/RenderObjectChildList.cpp:540
> -		       return;
> -		   }
> +		   generatedContentContainer =
createBeforeAfterGeneratedContentContainer(owner, renderer, styledObject,
pseudoElementStyle);

I don't think this change is right. We used to bail out if
|generatedContentContainer| was not allowed by |owner| and now we don't -
because it's missing a NULL-check. I guess that's why the EWS is unhappy.

Arguably this doesn't add much so I would advise just dropping this part of the
change unless you need that for your refactoring.