[webkit-reviews] review denied: [Bug 80760] WinLauncher should show loading errors : [Attachment 131215] Patch (Whitespaces)

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has denied Ashod Nakashian
<ashodnakashian at yahoo.com>'s request for review:
Bug 80760: WinLauncher should show loading errors
https://bugs.webkit.org/show_bug.cgi?id=80760

Attachment 131215: Patch (Whitespaces)
https://bugs.webkit.org/attachment.cgi?id=131215&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131215&action=review


AFAIK we usually DO NOT commit any whitespace only changes -> unusally we
remove it when we touch a line (+/- a few lines) which contains whitespace
whitspace is not nice, but does not hurt anybody during development, but it
creates unneded chages which make digging in svn log more complicated

> Tools/WinLauncher/WinLauncher.cpp:145
> +HRESULT WinLauncherWebHost::didFailProvisionalLoadWithError(IWebView
*webView, IWebError *error)

why do you still add this change? this and the other patch won't apply as two
independed changes (IMHO that's what brent requested)