[webkit-reviews] review denied: [Bug 80760] WinLauncher should show loading errors : [Attachment 131214] Patch (Functional)

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has denied Ashod Nakashian
<ashodnakashian at yahoo.com>'s request for review:
Bug 80760: WinLauncher should show loading errors
https://bugs.webkit.org/show_bug.cgi?id=80760

Attachment 131214: Patch (Functional)
https://bugs.webkit.org/attachment.cgi?id=131214&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=131214&action=review


> Tools/WinLauncher/WinLauncher.cpp:145
> +HRESULT WinLauncherWebHost::didFailProvisionalLoadWithError(IWebView
*webView, IWebError *error)

unuesed parameter webView

> Tools/WinLauncher/WinLauncher.cpp:147
> +    BSTR frameURL = 0;

unused variable frameURL

> Tools/WinLauncher/WinLauncher.cpp:149
> +    HRESULT hr = error->localizedDescription(&errorDescription);

unused variable hr -> please handle a possible error