[webkit-reviews] review denied: [Bug 80787] Web Inspector: provide access to process private and shared memory size : [Attachment 131224] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 80787: Web Inspector: provide access to process private and shared memory
size
https://bugs.webkit.org/show_bug.cgi?id=80787

Attachment 131224: Patch
https://bugs.webkit.org/attachment.cgi?id=131224&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131224&action=review


> Source/WebCore/page/MemoryInfo.cpp:64
> +    return PlatformSupport::processPrivateMemorySize();

I.e. total/user heap is static, while this private memory is alive on a given
instance? We should be consistent, preserve console.memory singleton and make
all the properties of the performance.* consistent?

> Source/WebCore/page/MemoryInfo.h:61
> +    RefPtr<Frame> m_frame;

You are at risk of leaking the frame here.