[webkit-reviews] review denied: [Bug 80786] Web Inspector: use monotonically increasing time in timeline agent : [Attachment 131220] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 80786: Web Inspector: use monotonically increasing time in timeline agent
https://bugs.webkit.org/show_bug.cgi?id=80786

Attachment 131220: Patch
https://bugs.webkit.org/attachment.cgi?id=131220&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=131220&action=review


Looks good with a nit. Could you please add a test?

> Source/WebCore/inspector/InspectorTimelineAgent.h:160
> +    double timestampFromMicroseconds(double microseconds) { return
(microseconds + m_timestampOffset) * 1000.0; }

Why is it implemented in header?